Change in ovirt-engine[master]: core: EngineExtensionsManager#normalizeName size optimization

Code Review gerrit at ovirt.org
Mon Apr 3 05:41:48 UTC 2017


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: core: EngineExtensionsManager#normalizeName size optimization
......................................................................


core: EngineExtensionsManager#normalizeName size optimization

The result of normalizeName always has the exact same size as the
input. Thus, the StringBuilder used to construct it can be
initialized to that size in order to avoid a (relatively) costly
extension of its size while appending characters.

Change-Id: I4cc073a53aa1407957c9b932abe37b53627a37bb
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/75037
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4cc073a53aa1407957c9b932abe37b53627a37bb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list