Change in ovirt-engine[master]: webadmin: Linq#IPredicate to extend java.util.Predicate

Code Review gerrit at ovirt.org
Thu Apr 6 19:05:12 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: Linq#IPredicate to extend java.util.Predicate
......................................................................


webadmin: Linq#IPredicate to extend java.util.Predicate

Linq#IPredicate basically serves the same purpose of
java.util.Predicate.
Now that oVirt uses a GWT version that supports JDK 8, IPredicate can
be retrofitted to extend Predicate, where the default implementation
of test would be to just call match.

This is a temporary approach which allows following patches to
incrementally remove usages of IPredicate and replace them with
java.util.Predicate until it can be completely removed.

Change-Id: Idf4b49681ed8bfede233e09d1209d50c48de19d2
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Idan Shaby: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/75165
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idf4b49681ed8bfede233e09d1209d50c48de19d2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list