Change in ovirt-engine[master]: webadmin: Linq#filterDisksByType null check

Code Review gerrit at ovirt.org
Thu Apr 6 19:05:13 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: Linq#filterDisksByType null check
......................................................................


webadmin: Linq#filterDisksByType null check

Checking null inside a filter method is unintuitive, and goes against
the convention of similar such methods in the Linq class.
Moreover, all the places the currently call this method already check
for a null input as part of a wider optimization.

This patch removes the null check from the filterDisksByType method
in order to clean up the code and set up further refactoring in the
following patches.

Change-Id: If90304d71315a5806a4b13d0a4e21fc1a7f13e04
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
1 file changed, 3 insertions(+), 5 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/75183
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If90304d71315a5806a4b13d0a4e21fc1a7f13e04
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list