Change in ovirt-engine[master]: webadmin: Inline Linq#retrieveFromSet

Code Review gerrit at ovirt.org
Thu Apr 6 19:05:13 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: Inline Linq#retrieveFromSet
......................................................................


webadmin: Inline Linq#retrieveFromSet

Linq#retrieveFromSet is only used in one place, RegisterVmModel, and
thus probably isn't a good fit for a general purpose class like Linq.

This patch removes this method and inlines the functionality to
RegisterVmModel with a single-statement Java 8 stream call.

Change-Id: I16239c1154a2b8a3c23ca221de837e763a538acb
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/RegisterVmModel.java
2 files changed, 6 insertions(+), 11 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/75192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I16239c1154a2b8a3c23ca221de837e763a538acb
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list