Change in ovirt-engine[master]: webadmin: Inline Linq#filterNonSnapableDisks

Code Review gerrit at ovirt.org
Thu Apr 6 19:05:14 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: Inline Linq#filterNonSnapableDisks
......................................................................


webadmin: Inline Linq#filterNonSnapableDisks

As Linq#filterNonSnapableDisks is only used in one place,
SnapshotMode, it's probably not a good fit for a general purpose
class like Linq, and should be removed from it.
This patch removes this function and inlines the functionality in
SnapshotModel. As an added bonus, this patch consolidates the
filtering and the sorting of the disks list, generating a slight
performance improvement.

Change-Id: Ic052700b9a88fc55e21399241a3d4d1b27e94f9b
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java
2 files changed, 8 insertions(+), 12 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/75185
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic052700b9a88fc55e21399241a3d4d1b27e94f9b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list