Change in ovirt-engine[master]: core: Remove static VmDevicesMonitoring instance

Code Review gerrit at ovirt.org
Sun Apr 9 15:05:45 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: Remove static VmDevicesMonitoring instance
......................................................................


core: Remove static VmDevicesMonitoring instance

Replaced error prone access of global static instance of VmsDevicesMonitoring
(facilitated by manual loading of BackendService in correct order in the
Backend initialization) with proper lazy CDI dependency resolution.

Change-Id: Ib16d56e7423130da404aa77d2158cd9f5ed5b90b
Signed-off-by: Martin Betak <mbetak at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmStatsRefresher.java
3 files changed, 7 insertions(+), 19 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Looks good to me, but someone else must approve
  Arik Hadas: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/75049
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib16d56e7423130da404aa77d2158cd9f5ed5b90b
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list