Change in ovirt-engine[master]: webadmin: Reimplement AbstractUserPortalListModel#onVmAndPoo...

Code Review gerrit at ovirt.org
Wed Apr 12 11:18:31 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: webadmin: Reimplement AbstractUserPortalListModel#onVmAndPoolLoad
......................................................................


webadmin: Reimplement AbstractUserPortalListModel#onVmAndPoolLoad

This patch reimplements onVmAndPoolLoad using Java 8's stream
capabilities. Using streams allows for a continuous processing of the
data the method retrieves and improves performance by avoiding
allocating temporary lists for each step of the process.

Linq.zip, which is left unused as a consequence of these changes, is
also removed as part of this patch.

Change-Id: Idf62b40e6b528b7c30e222f53b709e2d3d8ba944
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java
2 files changed, 12 insertions(+), 24 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/75455
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idf62b40e6b528b7c30e222f53b709e2d3d8ba944
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list