Change in ovirt-engine[master]: engine: Extract AuditLogable interface from AuditLogableBase

Code Review gerrit at ovirt.org
Thu Apr 27 07:29:47 UTC 2017


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: engine: Extract AuditLogable interface from AuditLogableBase
......................................................................


engine: Extract AuditLogable interface from AuditLogableBase

The interface will allow to use the AuditLogable outside of the contexts
of commands safetly. The AuditLogDirector will not make any assumptions
for the implementation of the logged entity.

By defining AuditLogable, we set the ground for introducing a POJO
implementation for AuditLogable which will avoid any need to inject
DAOs. However, it will require to speicfy the data explicitly.

Change-Id: I58ed8ca0ebadb381ecb67531a6c39a80ac90edc4
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogable.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/EventFloodRegulator.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/EventKeyComposer.java
5 files changed, 229 insertions(+), 63 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Moti Asayag: Verified
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/76046
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I58ed8ca0ebadb381ecb67531a6c39a80ac90edc4
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list