Change in ovirt-engine[master]: webadmin: fix data table link cell rendering

Code Review gerrit at ovirt.org
Tue Aug 1 19:57:56 UTC 2017


>From Greg Sheremeta <gshereme at redhat.com>:

Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80067 )

Change subject: webadmin: fix data table link cell rendering
......................................................................


webadmin: fix data table link cell rendering

The HTML composed by the text plus link cell was causing the
link to render incorrectly. By putting the link on its own,
with a small adjustment to the link style, the links will
match the text cells.

Change-Id: I45fcfa7c34ed1658bc4127c78d59b42187e04fd9
Signed-off-by: Scott J Dickerson <sdickers at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/LinkCell.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TextCell.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabCellTable.css
3 files changed, 51 insertions(+), 32 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Looks good to me, approved
  Scott Dickerson: Verified



-- 
To view, visit https://gerrit.ovirt.org/80067
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I45fcfa7c34ed1658bc4127c78d59b42187e04fd9
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list