Change in ovirt-engine[master]: core: reduce boilerplate code in ovf handling

Code Review gerrit at ovirt.org
Wed Aug 2 13:07:58 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79445 )

Change subject: core: reduce boilerplate code in ovf handling
......................................................................


core: reduce boilerplate code in ovf handling

Change VdsProperties class that contains the constants used for generating
and parsing OVFs to be an interface. That makes the code within OVF
writers and readers easier to read.

Change-Id: I627dae37e1a1500f777cf3231ae12e9d3d2b6912
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/HostedEngineOvfWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/IOvfBuilder.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
9 files changed, 282 insertions(+), 338 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Arik Hadas: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/79445
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I627dae37e1a1500f777cf3231ae12e9d3d2b6912
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list