Change in ovirt-engine[master]: core: always clone on import from cfme

Code Review gerrit at ovirt.org
Tue Aug 8 16:41:11 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80403 )

Change subject: core: always clone on import from cfme
......................................................................


core: always clone on import from cfme

When importing a VM not as a new entity (i.e., not cloning it), we preserve
its MAC address. This is also the case  when the mac address is out of the
MACs pool's range, which leads to unplugged NIC(s) for the imported VM.
As a temporary workaround, we change the import from external URL (i.e.,
only from external provider by CFME at the moment) to always clone the VM,
also when the VM doesn't exist in the system. This way, the MAC addresses
are reallocated during the import process.

Change-Id: I709a0dee90eeade0f7715e3be3242a6ce15e1f65
Bug-Url: https://bugzilla.redhat.com/1437152
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalUrlCommand.java
1 file changed, 4 insertions(+), 8 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Arik Hadas: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/80403
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I709a0dee90eeade0f7715e3be3242a6ce15e1f65
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list