Change in ovirt-engine[master]: core: QuotaDaoImpl#getAllQuotaIncludingConsumption nulls

Code Review gerrit at ovirt.org
Tue Aug 8 17:10:44 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79758 )

Change subject: core: QuotaDaoImpl#getAllQuotaIncludingConsumption nulls
......................................................................


core: QuotaDaoImpl#getAllQuotaIncludingConsumption nulls

executeReadList never returns null - in the case of a query that has
no data, it returns an empty list.
This patch removes the redundant (read: wrong) null checks from this
method's implementation in order to solve a Coverity warning.

Change-Id: I458377d1f3fb082397ac5abbb56e27b8055cead9
Coverity-CID: 1062067
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDaoImpl.java
1 file changed, 19 insertions(+), 23 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Martin Sivák: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/79758
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I458377d1f3fb082397ac5abbb56e27b8055cead9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list