Change in ovirt-engine[master]: core: Remove storage pool from StoragePoolIsoMapDaoTest

Code Review gerrit at ovirt.org
Tue Aug 8 17:10:46 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80262 )

Change subject: core: Remove storage pool from StoragePoolIsoMapDaoTest
......................................................................


core: Remove storage pool from StoragePoolIsoMapDaoTest

The only aspect of the storage pool used in StoragePoolIsoMapDaoTest
is it's ID, which is just given as a constant in FixturesTool.

This patch removes the redundant objects from the
StoragePoolIsoMapDaoTest to make it clearer and easier to maintain.
As a side bonus, it also removes another DAO call, speeding up the
test.

Change-Id: I6f214062fbd419547eac5a65e2b15b88af4b887c
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDaoTest.java
1 file changed, 4 insertions(+), 9 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/80262
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6f214062fbd419547eac5a65e2b15b88af4b887c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list