Change in ovirt-engine[master]: core: Fix VdsDynamicDaoTest#testSave

Code Review gerrit at ovirt.org
Tue Aug 8 17:10:48 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80280 )

Change subject: core: Fix VdsDynamicDaoTest#testSave
......................................................................


core: Fix VdsDynamicDaoTest#testSave

VdsDynamicDaoTest#testSave should only test saving a VdsDynamic
object to the database, and not rely on other DAOs.

This patch fixes the test by reusing the VDS_JUST_STATIC_ID record
and adding a VdsDyanmic record to it, so there's not need to create
another VdsStatic record.

Change-Id: I0b61687449b1cc2e5bc0a34c03f3b48830f4395f
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsStaticDaoTest.java
3 files changed, 8 insertions(+), 13 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/80280
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0b61687449b1cc2e5bc0a34c03f3b48830f4395f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list