Change in ovirt-engine[master]: core: Remove unused VmStatic[Dao] from VmInitDaoTest

Code Review gerrit at ovirt.org
Tue Aug 8 17:10:50 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80308 )

Change subject: core: Remove unused VmStatic[Dao] from VmInitDaoTest
......................................................................


core: Remove unused VmStatic[Dao] from VmInitDaoTest

Removed a useless VmStatic member and the VmStaticDao used to
initialize it, as they are not used at all in the test.

Besides cleaning up the test from redundant members, this patch also
speeds it up by saving a useless DAO call in the test's set up.

Change-Id: I788fc42f1052040be0ede139106277d40b79b6f3
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmInitDaoTest.java
1 file changed, 0 insertions(+), 7 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/80308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I788fc42f1052040be0ede139106277d40b79b6f3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list