Change in ovirt-engine[master]: core: Display an alert if the VM has illegal images

Code Review gerrit at ovirt.org
Tue Aug 8 19:00:55 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80113 )

Change subject: core: Display an alert if the VM has illegal images
......................................................................


core: Display an alert if the VM has illegal images

Display an alert next to the VM if the VM has illegal images. A VM may
have illegal images if, for example, there was a failure during merge.
It is important to display an alert because an illegal image may
indicate that the volume on the storage is illegal, because if the
VM is stopped, the user will not be able to start it again before fixing
the illegal volume.

Change-Id: I46bdceea155774bbb7641dd767c3caf4f53b8102
Bug-Url: https://bugzilla.redhat.com/1372163
Signed-off-by: Ala Hino <ahino at redhat.com>
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDaoImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusColumn.java
M packaging/dbscripts/create_views.sql
6 files changed, 34 insertions(+), 3 deletions(-)

Approvals:
  Eli Mesika: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Ala Hino: Verified
  Arik Hadas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/80113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I46bdceea155774bbb7641dd767c3caf4f53b8102
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list