Change in ovirt-engine[master]: webadmin: avoid NPE on String.join

Code Review gerrit at ovirt.org
Thu Aug 10 13:57:03 UTC 2017


>From Daniel Erez <derez at redhat.com>:

Daniel Erez has submitted this change and it was merged. ( https://gerrit.ovirt.org/80438 )

Change subject: webadmin: avoid NPE on String.join
......................................................................


webadmin: avoid NPE on String.join

StringUtils.join was replaced by String.join on
commit 88138bf0839d5b8d322cc1dfb1a706825ffeef06.

Consequently, disk selection on Disks tab is causing
an NPE on DiskGeneralModel -> updateProperties.

Change-Id: I61b4f882cd9c34abda0422e7825a5aa1fdc86917
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringHelper.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskGeneralModel.java
2 files changed, 12 insertions(+), 2 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Daniel Erez: Verified
  Jenkins CI: Passed CI tests
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/80438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I61b4f882cd9c34abda0422e7825a5aa1fdc86917
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list