Change in ovirt-engine[master]: core: DnsResolverConfigurationDaoTest to extend BaseGenericD...

Code Review gerrit at ovirt.org
Mon Aug 14 19:46:56 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80551 )

Change subject: core: DnsResolverConfigurationDaoTest to extend BaseGenericDaoTestCase
......................................................................


core: DnsResolverConfigurationDaoTest to extend BaseGenericDaoTestCase

Make DnsResolverConfigurationDaoTest extend BaseGenericDaoTestCase
instead of reimplementing its logic.

Change-Id: Ib755d5350c2641786216cabec08191b0ee90287d
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/DnsResolverConfigurationDaoTest.java
1 file changed, 29 insertions(+), 69 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Eli Mesika: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/80551
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib755d5350c2641786216cabec08191b0ee90287d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list