Change in ovirt-engine[master]: core: write vm custom properties to engine xml

Code Review gerrit at ovirt.org
Wed Aug 16 12:51:54 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80681 )

Change subject: core: write vm custom properties to engine xml
......................................................................


core: write vm custom properties to engine xml

Write the custom properties that are defined for a VM to the metadata section
in the engine xml. Specifically, this solves the issue of the vfio-mdev hook
not being called because of the lack of the mdev_type property.

An example of how the metadata section looks like with custom properties:
<domain type="kvm" xmlns:ovirt-vm="http://ovirt.org/vm/1.0">
  ... skipped ...
  <metadata>
    <ovirt-vm:vm>
      <ovirt-vm:version type="float">4.2</ovirt-vm:version>
      <ovirt-vm:custom>
        <ovirt-vm:mdev_type>arik</ovirt-vm:mdev_type>
      </ovirt-vm:custom>
    </ovirt-vm:vm>
  </metadata>
</domain>

Change-Id: I0b3a78e37bcdfe095b22f9b783260edd523bd06c
Bug-Url: https://bugzilla.redhat.com/1482033
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
1 file changed, 11 insertions(+), 0 deletions(-)

Approvals:
  Arik Hadas: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/80681
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0b3a78e37bcdfe095b22f9b783260edd523bd06c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list