Change in ovirt-engine[master]: core: missing injection caused NPE in event log

Code Review gerrit at ovirt.org
Tue Aug 22 08:16:07 UTC 2017


>From Eli Mesika <emesika at redhat.com>:

Eli Mesika has submitted this change and it was merged. ( https://gerrit.ovirt.org/80860 )

Change subject: core: missing injection caused NPE in event log
......................................................................


core: missing injection caused NPE in event log

When trying to dismiss an error (like in the case you try to add a host
to an incompatible dc/cluster version), a NPE is thrown as a result of
a AuditLogBase instance that is created without injecting its members.

This patch handled this problem by populating an AuditLogImpl instance
instead without a need of injection.

Change-Id: Ibe53da55b969962139b43b9701f8c100a2a40306
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1480208
Signed-off-by: emesika <emesika at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAuditLogByIdCommand.java
1 file changed, 18 insertions(+), 2 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Eli Mesika: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/80860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe53da55b969962139b43b9701f8c100a2a40306
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list