Change in ovirt-engine[master]: core: Execute ansible-playbook after otopi host-deploy

Code Review gerrit at ovirt.org
Tue Aug 22 17:16:08 UTC 2017


>From Martin Peřina <mperina at redhat.com>:

Martin Peřina has submitted this change and it was merged. ( https://gerrit.ovirt.org/78504 )

Change subject: core: Execute ansible-playbook after otopi host-deploy
......................................................................


core: Execute ansible-playbook after otopi host-deploy

This patch add new class called AnsibleExecutor, which executes
external command 'ansible-playbook'. The user can build a command
which will be executed, by adding attributes like additional
variables, hostnames, private key, etc.

Currently there is executed playbook called 'ovirt-host-deploy',
right after the otopi host-deploy is executed successfully.

This playbook is shipped via ovirt/ovirt-ansible github repository[1].
As developer you have to clone this repo and install it to your dev
env. For RPM users, the ovirt-engine RPM have dependency on this
repository.

Currently the ovirt-host-deploy playbook, will only execute the
ovirt-host-deploy role, which only implemente firewalld configuration
on the host.

[1] https://github.com/ovirt/ovirt-ansible

Change-Id: I630f10ceb451276053f0c44704dbf691f5498b7d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1462811
Signed-off-by: Ondra Machacek <omachace at redhat.com>
---
M Makefile
M README.adoc
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployIptablesUnit.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleCommandBuilder.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleConstants.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleExecutor.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleReturnCode.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleVerbosity.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/common/utils/ansible/AnsibleCommandBuilderTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M ovirt-engine.spec.in
16 files changed, 780 insertions(+), 5 deletions(-)

Approvals:
  Ondra Machacek: Verified
  Martin Peřina: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/78504
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I630f10ceb451276053f0c44704dbf691f5498b7d
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list