Change in ovirt-engine[master]: frontend: Unify usage of UIConstants in vNIC profile

Code Review gerrit at ovirt.org
Wed Aug 23 16:56:58 UTC 2017


>From Greg Sheremeta <gshereme at redhat.com>:

Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80901 )

Change subject: frontend: Unify usage of UIConstants in vNIC profile
......................................................................


frontend: Unify usage of UIConstants in vNIC profile

Add UIConstants in VnicProfileModel and use the constants variable
instead of calling ConstantsManager every time.

Change-Id: I1ab3710e98b80aec5ea048d73c0342e555f58c62
Signed-off-by: Ales Musil <amusil at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1435094
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/EditVnicProfileModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NewVnicProfileModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java
3 files changed, 11 insertions(+), 25 deletions(-)

Approvals:
  Ales Musil: Verified
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Looks good to me, approved
  Vojtech Szocs: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/80901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1ab3710e98b80aec5ea048d73c0342e555f58c62
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ales Musil <amusil at redhat.com>
Gerrit-Reviewer: Ales Musil <amusil at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list