Change in ovirt-engine[master]: Pass plugin type for each external network allocate request.

Code Review gerrit at ovirt.org
Wed Aug 30 06:24:49 UTC 2017


>From Alona Kaplan <alkaplan at redhat.com>:

Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80525 )

Change subject: Pass plugin type for each external network allocate request.
......................................................................


Pass plugin type for each external network allocate request.

Plugin type must be passed to vdsm whenever
a port is allocated. The plugin type can be used
to determine which provider driver will be executed,
and allow to have multiple drivers installed.
Currently the drivers have no way of knowing
which should be handling the nic.

This will also fix the problem where the
openstacknet driver can not be installed along
any of the other external network providers.
The openstack driver is checking for plugin
type before it decides to run or not to run.
With no plugin type, the openstacknet hooks
were failing, even if the nic belonged to
a different type of provider.

Bug-Url: https://bugzilla.redhat.com/1478823

Change-Id: I4f76d4f4e4e087bc88c9412705c168d4e1fa08c7
Signed-off-by: Marcin Mirecki <mmirecki at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java
2 files changed, 2 insertions(+), 12 deletions(-)

Approvals:
  Marcin Mirecki: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/80525
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4f76d4f4e4e087bc88c9412705c168d4e1fa08c7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list