Change in ovirt-engine[master]: core: remove fence_agents columns from vds view

Code Review gerrit at ovirt.org
Wed Aug 30 14:40:26 UTC 2017


>From Alexander Wels <awels at redhat.com>:

Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/75509 )

Change subject: core: remove fence_agents columns from vds view
......................................................................


core: remove fence_agents columns from vds view

Fence agents should be dropped from VDS view join.

In case of more then 1 fence agent is defined for a single host the
view returns the same host rows as many times as many agents are defined.
That is bug prone for the view user.
Beside that it has some performance impact on the queries related to VDS view.

This patch removes the fence_agents.* columns from the vds and
vds_with_tags views.

Change-Id: I8abee60df47a155882d7963f85a15c7cd490c870
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1434868
Signed-off-by: emesika <emesika at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M packaging/dbscripts/create_views.sql
5 files changed, 58 insertions(+), 79 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Eli Mesika: Verified
  Juan Hernandez: Looks good to me, but someone else must approve
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/75509
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8abee60df47a155882d7963f85a15c7cd490c870
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list