Change in ovirt-hosted-engine-ha[master]: rpc: Block on listen

Code Review gerrit at ovirt.org
Wed Aug 30 15:26:54 UTC 2017


>From Martin Sivák <msivak at redhat.com>:

Martin Sivák has submitted this change and it was merged. ( https://gerrit.ovirt.org/81225 )

Change subject: rpc: Block on listen
......................................................................


rpc: Block on listen

To implement safe shutdown procedure, We used (partially)
non-blocking listen call, that returned control back
after each accepted connection. With new RPC we can
safely block in listen forever and initiate shutdown on a signal.

https://github.com/oVirt/ovirt-site/pull/1157

Change-Id: Ieb7b0c4624ea8113720812617355b921ffa01dc8
Signed-off-by: Denis Chaplygin <dchaplyg at redhat.com>
---
M ovirt_hosted_engine_ha/broker/broker.py
M ovirt_hosted_engine_ha/broker/listener.py
2 files changed, 13 insertions(+), 31 deletions(-)

Approvals:
  Denis Chaplygin: Verified
  Martin Sivák: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/81225
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb7b0c4624ea8113720812617355b921ffa01dc8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Denis Chaplygin <dchaplyg at redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir at redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list