Change in ovirt-engine[master]: core: Sorting by multiple db columns

Code Review gerrit at ovirt.org
Wed Feb 1 08:07:18 UTC 2017


>From Shahar Havivi <shavivi at redhat.com>:

Shahar Havivi has submitted this change and it was merged.

Change subject: core: Sorting by multiple db columns
......................................................................


core: Sorting by multiple db columns

Backend sorting infrastructure altered in order to be able to sort by
multiple expressions (usually db columns). Each UI column may be mapped
to one or more such expressions (represented by class
SyntaxChecker.SortByElement) that are later transformed to on SQL 'ORDER
BY' clause.

Change-Id: I9dc9d50dc9892dfa628b547b15aa7abc1cb81a3e
Bug-Url: https://bugzilla.redhat.com/1273825
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/IConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java
5 files changed, 73 insertions(+), 12 deletions(-)

Approvals:
  Jakub Niedermertl: Verified
  Martin Peřina: Looks good to me, but someone else must approve
  Ravi Nori: Looks good to me, but someone else must approve
  Shahar Havivi: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/70901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9dc9d50dc9892dfa628b547b15aa7abc1cb81a3e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list