Change in ovirt-engine-sdk-ruby[master]: Don't specify the 'json' version

Code Review gerrit at ovirt.org
Wed Feb 1 14:57:57 UTC 2017


>From Juan Hernandez <juan.hernandez at redhat.com>:

Juan Hernandez has submitted this change and it was merged.

Change subject: Don't specify the 'json' version
......................................................................


Don't specify the 'json' version

Currently the SDK requires the 'json' gem using the following range
specification:

  spec.add_dependency('json', '~> 1.8')

This makes it incompatible with applications that want to use versio 2.0
or newer. But the SDK doesn't really need any advanced capability, it can
work with any version of the 'json' gem. To reduce the incompatibilities
this patch changes the SDK so that it doesn't specify the min version.
It will get 1.8 at least anyhow, has it is included with any Ruby 2
installation.

Change-Id: I62364b45e3782c17d51b3def0c4769e8e3aafed0
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M sdk/ovirt-engine-sdk.gemspec
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Boris Odnopozov: Looks good to me, but someone else must approve
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/71516
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I62364b45e3782c17d51b3def0c4769e8e3aafed0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Boris Odnopozov <bodnopoz at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list