Change in ovirt-engine[master]: core: OsValueAutoCompleterTest completions

Code Review gerrit at ovirt.org
Sun Feb 5 21:14:51 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: OsValueAutoCompleterTest completions
......................................................................


core: OsValueAutoCompleterTest completions

Initialize the static data member in a static block instead of
reinitializing it every instance of the test.
This is not only faster, but also makes debugging these tests much
easier, as it's clear where the map instance is created and populated.

Change-Id: I8255fca5b7fd9a1f002b14fea11b09f30c0d78a0
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleterTest.java
1 file changed, 9 insertions(+), 8 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/71661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8255fca5b7fd9a1f002b14fea11b09f30c0d78a0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list