Change in ovirt-engine[ovirt-engine-4.1]: core: Sorting by multiple db columns

Code Review gerrit at ovirt.org
Mon Feb 6 11:46:26 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: Sorting by multiple db columns
......................................................................


core: Sorting by multiple db columns

Backend sorting infrastructure altered in order to be able to sort by
multiple expressions (usually db columns). Each UI column may be mapped
to one or more such expressions (represented by class
SyntaxChecker.SortByElement) that are later transformed to on SQL 'ORDER
BY' clause.

Change-Id: I9dc9d50dc9892dfa628b547b15aa7abc1cb81a3e
Bug-Url: https://bugzilla.redhat.com/1273825
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/IConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java
5 files changed, 73 insertions(+), 12 deletions(-)

Approvals:
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/71512
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9dc9d50dc9892dfa628b547b15aa7abc1cb81a3e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list