Change in ovirt-engine[master]: core: add ID property to MacPool.

[Code Review]

>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: core: add ID property to MacPool.
......................................................................


core: add ID property to MacPool.

Adding ID to MacPool to be able to identify different MacPools in the
logs. The DB ID (mac_pools.id) will be used for this.

Note:
ID is not a 'required' property of in-memory object (with an exception
in compensation flow), and might bind itself to DB, it *is* a property
of MacPool, and a good candidate to identify pool. A pool is related
to db record, and has ID. It's very unlikely, that any future
implementation of pools won't be able to have ID, thus proceeding
without pool having ID is just complicating work for ourselves.

Change-Id: Icb688c24e9105850e70291a67d7fcc129773a9ca
Bug-Url: https://bugzilla.redhat.com/1395462
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/DecoratedMacPoolFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/DelegatingMacPoolDecorator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolDecorator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerCluster.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolUsingRanges.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/ReadMacPool.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/TransactionalMacPoolDecorator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/DecoratedMacPoolFactoryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerClusterTest.java
10 files changed, 91 insertions(+), 32 deletions(-)

Approvals:
  Martin Mucha: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved
  Yevgeny Zaspitsky: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/67054
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icb688c24e9105850e70291a67d7fcc129773a9ca
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>