Change in ovirt-engine-sdk[master]: Merge link with element if it has same name

Code Review gerrit at ovirt.org
Thu Feb 9 15:32:16 UTC 2017


>From Ondra Machacek <omachace at redhat.com>:

Ondra Machacek has submitted this change and it was merged.

Change subject: Merge link with element if it has same name
......................................................................


Merge link with element if it has same name

This patch merges the link and element if it has same name.

For example when API returns following XML:

 <root>
  <link href='/link' rel'attrs'/>
  <attrs>
    <attr id='123'/>
  </attrs>
 </root>

We must ensure that both the link and element are read and merged into
single attribute of Python SDK, so user can later access the 'href' of
the link as well as content of the 'attr' element.

Change-Id: Ied8cdd24632083967cbc5c4d5528c8c1cf02ab63
Signed-off-by: Ondra Machacek <omachace at redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/python/ReadersGenerator.java
A sdk/tests/test_affinity_group_reader.py
2 files changed, 101 insertions(+), 7 deletions(-)

Approvals:
  Ondra Machacek: Verified; Looks good to me, approved
  Juan Hernandez: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/71784
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ied8cdd24632083967cbc5c4d5528c8c1cf02ab63
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list