Change in ovirt-engine[ovirt-engine-4.1]: webadmin: unexpected TAB order in the external network subne...

Code Review gerrit at ovirt.org
Sun Feb 12 09:02:19 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: unexpected TAB order in the external network subnet window
......................................................................


webadmin: unexpected TAB order in the external network subnet window

Setting the tab order on the subnet window was not implemented.
Adding the code that sets the tab order.

Change-Id: I4358b972a10c740cdad4e7c0f5e7ca1ba489bc13
Bug-Url: https://bugzilla.redhat.com/1410405
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
Signed-off-by: mirecki <mmirecki at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ExternalSubnetPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/DnsServerEditor.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/DnsServersWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/ExternalSubnetWidget.java
5 files changed, 45 insertions(+), 7 deletions(-)

Approvals:
  Marcin Mirecki: Verified
  Jenkins CI: Passed CI tests
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/72012
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4358b972a10c740cdad4e7c0f5e7ca1ba489bc13
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list