Change in ovirt-engine[master]: core: ImagesHandler#prepareSnapshotConfigWithAlternateImage(...

Code Review gerrit at ovirt.org
Sun Feb 12 17:07:36 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: ImagesHandler#prepareSnapshotConfigWithAlternateImage(Snapshot, Guid, DiskImage)
......................................................................


core: ImagesHandler#prepareSnapshotConfigWithAlternateImage(Snapshot, Guid, DiskImage)

Inlined a convenience method that doesn't really add anything to the
code's readability. Moreover, it hides the OvfManager in a fashion it
can't be injected.

This patch exposes the OvfManager so following patches can call the
method with an injected OvfManger.

Change-Id: I10283b720abdee234e9a82e37872853677556b79
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java
2 files changed, 3 insertions(+), 6 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/71934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I10283b720abdee234e9a82e37872853677556b79
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list