Change in ovirt-engine[master]: core: GetGlusterGeoReplicationEligibleVolumesQueryTest streams

Code Review gerrit at ovirt.org
Mon Feb 13 10:52:19 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: GetGlusterGeoReplicationEligibleVolumesQueryTest streams
......................................................................


core: GetGlusterGeoReplicationEligibleVolumesQueryTest streams

This patch reimplments checkEquals with Java 8's stream. This new
implementation is not only shorter and easier to read, but also reduces
the time-complexity of the comparison from O(n*m) to O(n+m).

Change-Id: I68ab8c0a709cb1e46b7bf5beec179c3971d197b8
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQueryTest.java
1 file changed, 6 insertions(+), 13 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/72132
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I68ab8c0a709cb1e46b7bf5beec179c3971d197b8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list