Change in ovirt-engine[master]: core: GetUnregisteredBlockStorageDomainsQueryTest mocking

Code Review gerrit at ovirt.org
Mon Feb 13 10:52:20 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: GetUnregisteredBlockStorageDomainsQueryTest mocking
......................................................................


core: GetUnregisteredBlockStorageDomainsQueryTest mocking

Remove redundant mocking that adds nothing to the test and may actually
cause it to fail under strict mocking.

Change-Id: I26039b40c496646dfabd8cfdaeb48c9cae05e7cf
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/GetUnregisteredBlockStorageDomainsQueryTest.java
1 file changed, 0 insertions(+), 12 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests
  Maor Lipchuk: Looks good to me, approved

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/72130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I26039b40c496646dfabd8cfdaeb48c9cae05e7cf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list