Change in ovirt-engine[master]: core: GetVdsAndNetworkInterfacesByNetworkIdQueryTest mocking

Code Review gerrit at ovirt.org
Mon Feb 13 10:52:19 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: GetVdsAndNetworkInterfacesByNetworkIdQueryTest mocking
......................................................................


core: GetVdsAndNetworkInterfacesByNetworkIdQueryTest mocking

Remove redundant mocking that adds nothing to the test and may actually
cause it to fail under strict mocking.

Change-Id: I9c1463387f91dddd56fa2bc1bfa5c9b9be346c31
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetVdsAndNetworkInterfacesByNetworkIdQueryTest.java
1 file changed, 0 insertions(+), 15 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Martin Mucha: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/72133
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9c1463387f91dddd56fa2bc1bfa5c9b9be346c31
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list