Change in ovirt-engine[master]: core: createNetworkAttachmentWithIpv4Configuration args

Code Review gerrit at ovirt.org
Mon Feb 13 10:52:20 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: createNetworkAttachmentWithIpv4Configuration args
......................................................................


core: createNetworkAttachmentWithIpv4Configuration args

The netmask and address passed to
createNetworkAttachmentWithIpv4Configuration are always null. This patch
inlines these arguments to clean up the code and make it easier to read.

Change-Id: Idbc50dfc8ec23275ed56bb434d7ce49e87edfdcd
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java
1 file changed, 6 insertions(+), 11 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Martin Mucha: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/72129
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idbc50dfc8ec23275ed56bb434d7ce49e87edfdcd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list