Change in ovirt-engine[master]: engine: Avoid PCI address conflict when existing interface i...

Code Review gerrit at ovirt.org
Mon Feb 13 11:54:40 UTC 2017


>From Alona Kaplan <alkaplan at redhat.com>:

Alona Kaplan has submitted this change and it was merged.

Change subject: engine: Avoid PCI address conflict when existing interface is in an ambiguous state.
......................................................................


engine: Avoid PCI address conflict when existing interface is in an ambiguous state.

Updating vm device in DB by VM monitoring after plugging can take some time.
During this time the user could request to plug another device. During this
time the new device could use a duplicated PCI address.
This patch safeguards us against this.

Change-Id: I3a998cb2de239eb69acda6e50ac08e15b8d6e5be
Signed-off-by: Marcin Mirecki <mmirecki at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1412074
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Marcin Mirecki: Verified
  Martin Mucha: Looks good to me, but someone else must approve
  Alona Kaplan: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/72064
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3a998cb2de239eb69acda6e50ac08e15b8d6e5be
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list