Change in ovirt-engine[master]: core: InjectRule static inner classes

Code Review gerrit at ovirt.org
Mon Feb 13 18:13:45 UTC 2017


>From Allon Mureinik <amureini at redhat.com>:

Allon Mureinik has submitted this change and it was merged.

Change subject: core: InjectRule static inner classes
......................................................................


core: InjectRule static inner classes

InjectorRule's inner classes don't use any data and/or functionality
from their enclosing classes, so they can be simplified to static inner
classes.

More importantly, this prevents the CDI to hold a reference to the
first InjectRule created by its inner TestCDIProvider, so the garbage
collector can pick it up.

Change-Id: I75aade124728868a9da825f8b40de8a0f230ff76
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/di/InjectorRule.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/72213
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I75aade124728868a9da825f8b40de8a0f230ff76
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list