Change in ovirt-engine[ovirt-engine-4.1]: webadmin: edit vfs: dynamically maintain suggested labels

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: edit vfs: dynamically maintain suggested labels
......................................................................


webadmin: edit vfs: dynamically maintain suggested labels

Fixing a bug where labels are being generated once during
VfsNicLabelModel's instantiation and aren't maintained throughout
the configuration of the physical function.

suggestedLabels is now maintained (updateSuggestedLabels is
triggered on onValueChange and modifies it) and the underlying
ListModels setItems are invoked with the now up-to-date
variation of suggestedLabels.

Bug-Id: https://bugzilla.redhat.com/1410322
Signed-off-by: Leon Goldberg <lgoldber at redhat.com>
Change-Id: I0f17638dd2e55ebde99bdd00a044b691e32da29b
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/VfsConfigModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/VfsConfigNetwork.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/VfsNicLabelModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/VfsNicLabelWidget.java
6 files changed, 28 insertions(+), 18 deletions(-)

Approvals:
  Alona Kaplan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Leon Goldberg: Verified



-- 
To view, visit https://gerrit.ovirt.org/72258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0f17638dd2e55ebde99bdd00a044b691e32da29b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Leon Goldberg <lgoldber at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>