Change in ovirt-engine[ovirt-engine-4.1]: restapi: Null-safe handling of incorrect disks in Sparsify

[Code Review]

>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: restapi: Null-safe handling of incorrect disks in Sparsify
......................................................................


restapi: Null-safe handling of incorrect disks in Sparsify

Passing incorrect disk IDs or IDs of direct LUNs or Cinder disks to
SparsifyImageCommand via REST API causes NullPointerException. This
patch adds safety checks to avoid this situation.

Change-Id: Ie2b6b7f29a866f1e5f140754f73a04a20bfaad45
Bug-Url: https://bugzilla.redhat.com/1415759
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/SparsifyImageCommand.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java
2 files changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Juan Hernandez: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/72267
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2b6b7f29a866f1e5f140754f73a04a20bfaad45
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>