Change in ovirt-engine-sdk[sdk_4.1]: Don't generate custom tarball

Code Review gerrit at ovirt.org
Fri Feb 17 09:28:46 UTC 2017


>From Ondra Machacek <omachace at redhat.com>:

Ondra Machacek has submitted this change and it was merged.

Change subject: Don't generate custom tarball
......................................................................


Don't generate custom tarball

Currently the SDK generates a tarball using the 'tar' command
explicitly. This tarball is different to the one generated by the
distutils 'sdist' command (which is also executed as part of the build).
To avoid differences between the files published in the oVirt web site
and the files published in PyPI, this patch changes the automation
scripts so that this custom tarball is replaced by the tarball generated
by the 'sdist' command. In addition, and in order to achieve that, the
patch also changes the way that the version numbers of the SDK are
generated, so that they follow the advices of PEP440. Note that these
changes in version numbers only apply to non release builds, release
builds already used PEP440 version numbers.

Change-Id: I8febc38acb3980ea78229ba384f1140273866a86
Bug-Url: https://bugzilla.redhat.com/1422979
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M automation/build.py
M sdk/MANIFEST.in
2 files changed, 29 insertions(+), 26 deletions(-)

Approvals:
  Ondra Machacek: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/72487
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8febc38acb3980ea78229ba384f1140273866a86
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list