Change in ovirt-engine[master]: core: Adjust the limit on max VCPUs

Code Review gerrit at ovirt.org
Mon Feb 20 07:07:24 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: Adjust the limit on max VCPUs
......................................................................


core: Adjust the limit on max VCPUs

The maximum number of VCPUs must be multiplication of sockets * cores.  This is
ensured by the formula computing the maximum number of VCPUs, but the
configuration value may not satisfy that constraint.  So if we are limited by
the configuration value then we must check and adjust that value.

This is mostly theoretical in 4.1+ since the current configuration value (288)
is higher than the APIC limit (255) so it should cause no trouble in the
default 4.1 configuration.

Change-Id: I857e1a85950a863752e02a30066f682fff04a7c7
Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmCpuCountHelper.java
1 file changed, 9 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Arik Hadas: Looks good to me, approved
  Milan Zamazal: Verified



-- 
To view, visit https://gerrit.ovirt.org/72378
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I857e1a85950a863752e02a30066f682fff04a7c7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list