Change in ovirt-engine-sdk-ruby[sdk_4.0]: Don't fork the Maven source plugin

Code Review gerrit at ovirt.org
Mon Feb 27 11:19:11 UTC 2017


>From Juan Hernandez <juan.hernandez at redhat.com>:

Juan Hernandez has submitted this change and it was merged.

Change subject: Don't fork the Maven source plugin
......................................................................


Don't fork the Maven source plugin

Currently the project runs the 'jar' goal of the Maven source plugin.u
A side effect of this is that the plugin explicitly executes the
'generate-sources' phase of the build. As a result the code generation,
which is attached to that 'generate-sources' phase, runs twice. That
doesn't have a big impact, as the generated code is the same, but it
wastes resources. This patch changes the build process so that it uses
the 'jar-no-fork', which doesn't have that negative side effect.

Change-Id: I107a12125f5acb229608b05efba3572f24ebfe3d
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
(cherry picked from commit bdb11f9394b5d6e76e4cafeaf2e6aded0f2156e0)
(cherry picked from commit 3ea144fba2b9f4f993c0731cf9fd1476b9e3f651)
---
M pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/73124
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I107a12125f5acb229608b05efba3572f24ebfe3d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list