Change in ovirt-engine[ovirt-engine-4.1.1.z]: webadmin: Move updateBondOptions to SetupNetworksBondModel

Code Review gerrit at ovirt.org
Mon Feb 27 13:54:59 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: Move updateBondOptions to SetupNetworksBondModel
......................................................................


webadmin: Move updateBondOptions to SetupNetworksBondModel

SetupNetworksBondPopupView.updateBondOptions() updates the value of
customBondEditor manually via the view. Setting the value this way
doesn't fire any event. Therefore, the model is not updated during
initialization.

Moving updateBondOptions() and its registration to
SetupNetworksBondModel fixes this behavior.

Change-Id: I6a16a729633c3e1bd90a47689dbaffa9d5e813d8
Bug-Url: https://bugzilla.redhat.com/1424813
Signed-off-by: Dominik Holler <dholler at redhat.com>
(cherry picked from commit d33523ddb5e7a6cba2b85e8ff25c9be3c6470cf8)
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksBondModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java
2 files changed, 19 insertions(+), 26 deletions(-)

Approvals:
  Dominik Holler: Verified
  Alona Kaplan: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/73050
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a16a729633c3e1bd90a47689dbaffa9d5e813d8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.1.z
Gerrit-Owner: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>


More information about the Engine-commits mailing list