Change in jenkins[master]: Re-factored standard-ci builders

Code Review gerrit at ovirt.org
Mon Jan 2 13:48:16 UTC 2017


>From Barak Korren <bkorren at redhat.com>:

Barak Korren has submitted this change and it was merged.

Change subject: Re-factored standard-ci builders
......................................................................


Re-factored standard-ci builders

- Reduced code duplicaiton
- Improved log output and error checking
- Inlined the code into YAML for easier maintainance (!include* is the
  root of a lot of evil)

Change-Id: I73754db1ab0b363362a80210b8c2e312bf248541
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-994
Signed-off-by: Barak Korren <bkorren at redhat.com>
---
D jobs/confs/shell-scripts/standard_build_artifacts.sh
D jobs/confs/shell-scripts/standard_build_artifacts_manual.sh
D jobs/confs/shell-scripts/standard_check_merged.sh
D jobs/confs/shell-scripts/standard_check_patch.sh
M jobs/confs/yaml/builders/standard.yaml
M jobs/confs/yaml/templates/standard-stage.yaml
6 files changed, 44 insertions(+), 128 deletions(-)

Approvals:
  Eyal Edri: Looks good to me
  Barak Korren: Verified; Looks good to me, approved; Ready for merge
  Gil Shinar: Looks good to me
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/69375
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I73754db1ab0b363362a80210b8c2e312bf248541
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk at redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: David Caro <david at dcaro.es>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list