Change in ovirt-engine[master]: core: cache unplugged passthrough nics on vm migration

Code Review gerrit at ovirt.org
Mon Jan 2 14:20:22 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: cache unplugged passthrough nics on vm migration
......................................................................


core: cache unplugged passthrough nics on vm migration

This has two benefits:
1. Better performance - not to query VM's passthrough network interfaces on every
migration attempt.

2. We can always retrieve the unplugged NICs when migration succeed. Previously,
when one migration attempt failed, these NICs were cleared and so if the next
migration attempt would have succeed, they could not be plugged back.

Change-Id: Ib5437fdc8fd87bd5fa2b785097c13a6f76c2c8fc
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 26 insertions(+), 19 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Martin Mucha: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/69111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5437fdc8fd87bd5fa2b785097c13a6f76c2c8fc
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list