Change in ovirt-engine[master]: core: allow ipv6 address for migration role in cluster network

Code Review gerrit at ovirt.org
Thu Jan 5 09:12:08 UTC 2017


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: core: allow ipv6 address for migration role in cluster network
......................................................................


core: allow ipv6 address for migration role in cluster network

we're now allowing migration networks to consist of interfaces
that solely use ipv6. it is already possible to setup a host migration
attachment to use ipv6, however it is not possible to set migration role
when some host in a cluster doesn't have an ipv4 address in the relevant
nic.

when determining what's considered a missing ip in a nic, check for the
role of the cluster network, and if it's migration, consider it to be
missing only if both ipv6 and ipv4 addresses are missing.

Change-Id: Iae51623ebbfc2431d5f42f1e026c853afbbedb5a
Signed-off-by: Leon Goldberg <lgoldber at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidatorBase.java
1 file changed, 12 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Leon Goldberg: Verified
  Moti Asayag: Looks good to me, approved
  Yevgeny Zaspitsky: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/68996
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iae51623ebbfc2431d5f42f1e026c853afbbedb5a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber at redhat.com>
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list