Change in ovirt-engine[ovirt-engine-4.1]: core: cache unplugged passthrough nics on vm migration

Code Review gerrit at ovirt.org
Thu Jan 5 09:49:15 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged.

Change subject: core: cache unplugged passthrough nics on vm migration
......................................................................


core: cache unplugged passthrough nics on vm migration

This has two benefits:
1. Better performance - not to query VM's passthrough network interfaces on every
migration attempt.

2. We can always retrieve the unplugged NICs when migration succeed. Previously,
when one migration attempt failed, these NICs were cleared and so if the next
migration attempt would have succeed, they could not be plugged back.

Change-Id: Ib5437fdc8fd87bd5fa2b785097c13a6f76c2c8fc
Bug-Url: https://bugzilla.redhat.com/1408834
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 26 insertions(+), 19 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/69675
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5437fdc8fd87bd5fa2b785097c13a6f76c2c8fc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list