Change in ovirt-engine[master]: userportal, webadmin: fixed prohibition reason tooltips

Code Review gerrit at ovirt.org
Thu Jan 5 19:47:49 UTC 2017


>From Greg Sheremeta <gshereme at redhat.com>:

Greg Sheremeta has submitted this change and it was merged.

Change subject: userportal, webadmin: fixed prohibition reason tooltips
......................................................................


userportal, webadmin: fixed prohibition reason tooltips

UICommandButton and UICommandLink had bad logic for computing
the tooltip. This was causing a comma to render at the beginning
of the tooltip. Fixed.

Also replaced the comma with a much nicer line break when there
are multiple change prohibition reasons.

Change-Id: Ic5a0be9f87970a41a63f0a047ae791fd6037e5e7
Bug-Url: https://bugzilla.redhat.com/1396512
Signed-off-by: Greg Sheremeta <gshereme at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/UiCommandButton.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/UiCommandLink.java
2 files changed, 19 insertions(+), 14 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Verified



-- 
To view, visit https://gerrit.ovirt.org/68939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5a0be9f87970a41a63f0a047ae791fd6037e5e7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list